Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install openssh-client package for ssh command-line utilities #11545

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

dmitris
Copy link
Contributor

@dmitris dmitris commented Feb 11, 2025

What are you trying to accomplish?

Install openssh-client package as the initial step of the changes to propagate SSH credentials into the development / updater container and use them if necessary for repository access. Related to issue #11544.

Anything you want to highlight for special attention from reviewers?

This is the initial step to add the feature. For now, the apt package openssl-client is installed but not yet used. See the issue for the proposed steps to follow this one.

How will you know you've accomplished your goal?

After starting the development shell for example with bin/docker-dev-shell go_modules, one can run:

$ which ssh-add
/usr/bin/ssh-add

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@dmitris dmitris requested a review from a team as a code owner February 11, 2025 12:08
@dmitris dmitris force-pushed the ssh-in-docker-images branch 6 times, most recently from 22f0105 to 564ead0 Compare February 12, 2025 17:31
@dmitris dmitris marked this pull request as draft February 12, 2025 18:30
@dmitris dmitris force-pushed the ssh-in-docker-images branch from 564ead0 to 5d9d9cf Compare February 12, 2025 18:37
@thavaahariharangit thavaahariharangit self-assigned this Feb 13, 2025
@dmitris dmitris force-pushed the ssh-in-docker-images branch from 5d9d9cf to 92d0173 Compare February 13, 2025 16:53
@dmitris dmitris marked this pull request as ready for review February 13, 2025 16:53
@dmitris dmitris force-pushed the ssh-in-docker-images branch from 92d0173 to 1bc0aa4 Compare February 13, 2025 17:12
Install openssh-client package as the initial step of the changes
to propagate SSH credentials into the development / updater
container and use them if necessary for repository access.
Related to dependabot#11544.
@dmitris dmitris force-pushed the ssh-in-docker-images branch from 1bc0aa4 to 235bf9a Compare February 13, 2025 21:10
@thavaahariharangit thavaahariharangit merged commit 92370ad into dependabot:main Feb 14, 2025
110 of 113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants