Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make helper function return deterministic #11573

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

brettfo
Copy link
Contributor

@brettfo brettfo commented Feb 12, 2025

A unit test recently started acting up and the investigation showed that a helper function wasn't explicitly ordering its return value.

@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Feb 12, 2025
@brettfo brettfo force-pushed the dev/brettfo/nuget-file-order branch from 0cfeaaa to 711f3d7 Compare February 12, 2025 21:45
@brettfo brettfo force-pushed the dev/brettfo/nuget-file-order branch from 711f3d7 to b9c8864 Compare February 12, 2025 21:46
@brettfo brettfo marked this pull request as ready for review February 12, 2025 22:18
@brettfo brettfo requested a review from a team as a code owner February 12, 2025 22:18
@abdulapopoola abdulapopoola merged commit 496ead8 into main Feb 12, 2025
94 checks passed
@abdulapopoola abdulapopoola deleted the dev/brettfo/nuget-file-order branch February 12, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants