Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FromAsCasing error fixes. #11582

Merged
merged 3 commits into from
Feb 13, 2025
Merged

FromAsCasing error fixes. #11582

merged 3 commits into from
Feb 13, 2025

Conversation

thavaahariharangit
Copy link
Contributor

@thavaahariharangit thavaahariharangit commented Feb 13, 2025 •
edited
Loading

What are you trying to accomplish?

Fixing the FromAsCasing warning that I found in the python docker build.

Anything you want to highlight for special attention from reviewers?

image

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@thavaahariharangit thavaahariharangit requested a review from a team as a code owner February 13, 2025 10:37
@robaiken
Copy link
Contributor

Is this an issue with other docker files?

@github-actions github-actions bot added L: go:modules Golang modules L: rust:cargo Rust crates via cargo labels Feb 13, 2025
@thavaahariharangit
Copy link
Contributor Author

Is this an issue with other docker files?

Thanks and updated :)

@thavaahariharangit thavaahariharangit merged commit 17dc47a into main Feb 13, 2025
73 of 75 checks passed
@thavaahariharangit thavaahariharangit deleted the harry/fixing-as-keyword-casing-warning branch February 13, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robaiken robaiken robaiken approved these changes

Assignees
No one assigned
Labels
L: go:modules Golang modules L: python L: rust:cargo Rust crates via cargo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thavaahariharangit @robaiken