Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for the new bun ecosystem #11585

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

markhallen
Copy link
Contributor

@markhallen markhallen commented Feb 13, 2025

What are you trying to accomplish?

As part of our work to support bun in its own ecosystem we are adding specs to cover the functionality.

Part of #6528

The specs revealed that we should update the regex used in bun/lib/dependabot/bun/file_updater.rb

Added specs for:

  • BunPackageManager
  • FileFetcher
  • FileParser::LockfileParser
  • FileParser
  • FileUpdater
  • Requirement

Ans required fixtures.

Anything you want to highlight for special attention from reviewers?

Check that coverage is adequate.

How will you know you've accomplished your goal?

The regex used by the updater doesn't appear to causes issues as full testing has already taken place and produced the expected PRs. We should pay attention for any adverse reactions though.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@markhallen markhallen requested a review from a team as a code owner February 13, 2025 13:30
@markhallen markhallen force-pushed the add-specs-for-bun-ecosystem branch from 617d68d to d7275db Compare February 13, 2025 13:39
@markhallen markhallen force-pushed the add-specs-for-bun-ecosystem branch from d7275db to 8419167 Compare February 13, 2025 13:43
@markhallen markhallen merged commit eca15c1 into main Feb 13, 2025
58 checks passed
@markhallen markhallen deleted the add-specs-for-bun-ecosystem branch February 13, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants