Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make elm/version.rb sorbet typing strict #11598

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

amazimbe
Copy link
Contributor

What are you trying to accomplish?

Improve the sorbet typing in elm/version.rb from true to strict.

How will you know you've accomplished your goal?

All CI checks should continue to pass as before.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@amazimbe amazimbe requested a review from a team as a code owner February 14, 2025 11:05
@github-actions github-actions bot added the L: elm Elm packages label Feb 14, 2025
@amazimbe amazimbe self-assigned this Feb 14, 2025
@amazimbe amazimbe force-pushed the amazimbe/add-srb-typing-to-elm-version branch from 80583d4 to 067215e Compare February 14, 2025 11:19
@amazimbe amazimbe merged commit fec5646 into main Feb 14, 2025
59 checks passed
@amazimbe amazimbe deleted the amazimbe/add-srb-typing-to-elm-version branch February 14, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: elm Elm packages
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants