Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expand error patterns for missing packages #11605

Merged
merged 1 commit into from
Feb 19, 2025
Merged

expand error patterns for missing packages #11605

merged 1 commit into from
Feb 19, 2025

Conversation

brettfo
Copy link
Contributor

@brettfo brettfo commented Feb 14, 2025 •
edited
Loading

Include more error message patterns for missing packages.

The dependency_not_found error can happen during NuGet fetch so a corresponding entry was added to fetcher_error_details to match the entry in updater_error_details in errors.rb.

@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Feb 14, 2025
@brettfo brettfo force-pushed the dev/brettfo/nuget-package-not-found branch from 182e70e to 0f0cad4 Compare February 14, 2025 22:14
@brettfo brettfo marked this pull request as ready for review February 14, 2025 23:02
@brettfo brettfo requested review from a team as code owners February 14, 2025 23:02
@brettfo brettfo force-pushed the dev/brettfo/nuget-package-not-found branch from 0f0cad4 to 805d334 Compare February 19, 2025 16:57
randhircs
randhircs approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@randhircs randhircs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve it.

@randhircs randhircs force-pushed the dev/brettfo/nuget-package-not-found branch from 805d334 to dd60005 Compare February 19, 2025 18:52
@randhircs randhircs merged commit 40e87c6 into main Feb 19, 2025
129 of 132 checks passed
@randhircs randhircs deleted the dev/brettfo/nuget-package-not-found branch February 19, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamieMagee JamieMagee JamieMagee approved these changes

@randhircs randhircs randhircs approved these changes

Assignees
No one assigned
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brettfo @JamieMagee @randhircs