Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET 9 as a supported framework #11619

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

patrikwlund
Copy link
Contributor

What are you trying to accomplish?

I want to add .NET 9 to the list of supported frameworks, and thus to the "compatibility matrix", so that updates of packages targeting older versions of the framework are allowed.

Package update are currently rejected with the following message when not directly targeting NET 9:

The package <package-name>.<package-version> is not compatible. Incompatible project frameworks: net9.0

Fixes: #11516

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

.NET 9 projects receive updates for packages that target older (pre 9) framework versions.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@patrikwlund patrikwlund requested a review from a team as a code owner February 17, 2025 07:59
@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Feb 17, 2025
@patrikwlund patrikwlund changed the title Add .NET 9 as a target framework Add .NET 9 as a supported framework Feb 17, 2025
@martincostello
Copy link
Contributor

In a separate PR, would be good to have this refactored in a way that unless/until something comes along that needs specific attention because it breaks current assumptions/patterns, this "just works" for future .NET versions so it doesn't need changing again for .NET 10, 11 etc. for the form net{major.minor}.

@patrikwlund
Copy link
Contributor Author

would be good to have this refactored

I agree. Making these additions felt a bit silly.

@patrikwlund
Copy link
Contributor Author

It looks like one of the smoke tests failed because of a 504 when fetching https://api.nuget.org/v3-flatcontainer/system.buffers/index.json. Seems like a temporary network issue. Probably have to re-run the failed tests.

@randhircs randhircs force-pushed the nuget-net9-support branch 2 times, most recently from 3639433 to 7d84939 Compare February 19, 2025 20:45
@randhircs randhircs merged commit 37288c7 into dependabot:main Feb 19, 2025
81 of 104 checks passed
brettfo pushed a commit that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NuGet updates not applied due to incorrect compatibility determination
5 participants