-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error handling of security updates for conflicting target dependencies #11621
Merged
thavaahariharangit
merged 21 commits into
main
from
harry/error-handling-of-security-updates-conflicting-target-dependency
Feb 19, 2025
Merged
Error handling of security updates for conflicting target dependencies #11621
thavaahariharangit
merged 21 commits into
main
from
harry/error-handling-of-security-updates-conflicting-target-dependency
Feb 19, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flicting-target-dependency
amazimbe
reviewed
Feb 19, 2025
updater/lib/dependabot/updater/operations/create_security_update_pull_request.rb
Outdated
Show resolved
Hide resolved
amazimbe
reviewed
Feb 19, 2025
updater/lib/dependabot/updater/operations/create_security_update_pull_request.rb
Show resolved
Hide resolved
amazimbe
approved these changes
Feb 19, 2025
dmitris
pushed a commit
to dmitris/dependabot-core
that referenced
this pull request
Feb 26, 2025
dependabot#11621) * Error handling of security updates * Updated rspec * Update the error as transitive_update_not_possible * Lint fixes. * Removing the message. * Fixing the smoketest failure. * Fix sorbet error. * Fixing the smoke test. * Fixing the rspec error. * Fixing the test. * Refactoring the code * Refactoring the code * Fixing the Lint errors. * Code clean up and refactor. * RSpec added to my changes. * Updated the lowest resolvable version. * Updated as per the review comment. * Sorbet fixes. --------- Co-authored-by: “Thavachelvam <“[email protected]”>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
If the vulnerable dependency versions required via transitive dependency. then the update is not possible.
package-b current version "1.1.0" and it is vulnerable
it's lowest non vulnerable version is "1.2.0"
But package-a (1.2.0) requires package-c(1.2.0)
and the package-c(1.2.0) requires package-b(1.1.0)
In this scenario package-b cannot be updated.
We need to throw an error
transitive_update_not_possible
in this scenarioAnd logs should be updated with the expanation.
Anything you want to highlight for special attention from reviewers?
Current functionality can be found in this workflow
Root cause of the problem
Lowest non vulnerable version
0.1.12
(@vulnerable_version_strings=["< 0.1.12"]
) but the current version0.1.7
and it is vulnerable.But we cannot update this(
[email protected]
) as this is required by [email protected] via a transitive dependency.After this PR changes logs look like this
How will you know you've accomplished your goal?
Checklist