-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove FF and tests for npm6 deprecation and unsupported error #11622
Conversation
0672ba8
to
d008325
Compare
4b37d7b
to
2ff024b
Compare
9052b16
to
43a947e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The submodule NuGet.Client
has been deleted, this change needs to be reverted
Well spotted! I noticed it too and I'm removing it. |
43a947e
to
822ef10
Compare
What are you trying to accomplish?
NPM 6 was deprecated last December and it's no longer supported. However, that change was released under two feature flags that are now no longer needed. This PR removes the feature flags. Also note that the code in npm_and_yarn that detects the user version is controlled by 3 other feature flags so the tests have been updated accordingly under these new conditions.
Improve readability and maintainability by removing unnecessary feature flags and conditional statements.
How will you know you've accomplished your goal?
Checklist