Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FF and tests for npm6 deprecation and unsupported error #11622

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

amazimbe
Copy link
Contributor

@amazimbe amazimbe commented Feb 17, 2025

What are you trying to accomplish?

NPM 6 was deprecated last December and it's no longer supported. However, that change was released under two feature flags that are now no longer needed. This PR removes the feature flags. Also note that the code in npm_and_yarn that detects the user version is controlled by 3 other feature flags so the tests have been updated accordingly under these new conditions.

Improve readability and maintainability by removing unnecessary feature flags and conditional statements.

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@amazimbe amazimbe self-assigned this Feb 17, 2025
@amazimbe amazimbe force-pushed the amazimbe/npm6-deprecation-ff-cleanup branch 2 times, most recently from 0672ba8 to d008325 Compare February 20, 2025 11:39
@amazimbe amazimbe force-pushed the amazimbe/npm6-deprecation-ff-cleanup branch 4 times, most recently from 4b37d7b to 2ff024b Compare February 28, 2025 17:24
@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Feb 28, 2025
@amazimbe amazimbe force-pushed the amazimbe/npm6-deprecation-ff-cleanup branch 6 times, most recently from 9052b16 to 43a947e Compare March 6, 2025 11:15
@amazimbe amazimbe marked this pull request as ready for review March 6, 2025 11:16
@amazimbe amazimbe requested review from a team as code owners March 6, 2025 11:16
@amazimbe amazimbe requested review from robaiken and markhallen March 6, 2025 11:17
markhallen
markhallen previously approved these changes Mar 6, 2025
Copy link
Contributor

@markhallen markhallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@robaiken robaiken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The submodule NuGet.Client has been deleted, this change needs to be reverted

@amazimbe
Copy link
Contributor Author

amazimbe commented Mar 6, 2025

The submodule NuGet.Client has been deleted, this change needs to be reverted

Well spotted! I noticed it too and I'm removing it.

@amazimbe amazimbe force-pushed the amazimbe/npm6-deprecation-ff-cleanup branch from 43a947e to 822ef10 Compare March 6, 2025 12:39
@amazimbe amazimbe removed the request for review from a team March 6, 2025 12:58
@amazimbe amazimbe merged commit 1bdd864 into main Mar 6, 2025
74 checks passed
@amazimbe amazimbe deleted the amazimbe/npm6-deprecation-ff-cleanup branch March 6, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet L: javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants