Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the javascript folder #11623

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

markhallen
Copy link
Contributor

@markhallen markhallen commented Feb 18, 2025

What are you trying to accomplish?

Tidy up the repository by removing the javascript folder after the pivot to #11559

Anything you want to highlight for special attention from reviewers?

The removal should be relatively clean as all code is contained in the javascript folder. We also removed the related issue labeler config and the sorbet exclusion for javascript/spec.

How will you know you've accomplished your goal?

Everything should still work as it was except dry run with javascript.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@markhallen markhallen requested a review from a team as a code owner February 18, 2025 10:13
@markhallen markhallen merged commit 1213dc1 into main Feb 18, 2025
56 checks passed
@markhallen markhallen deleted the markhallen/remove-javascript-folder branch February 18, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants