Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python 3.8 deprecation / unsupported FFs and cleanup tests #11627

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

amazimbe
Copy link
Contributor

@amazimbe amazimbe commented Feb 18, 2025

What are you trying to accomplish?

In order to support the smooth deprecation of python 3.8 we added two feature flags: python_3_8_deprecation_warning and python_3_8_unsupported_error. As we stopped supporting python 3.8 on 5th February 2025, these feature flags are no longer required and this PR removes them to make the code easier to maintain.

How will you know you've accomplished your goal?

After this PR is merged, the feature flags python_3_8_deprecation_warning and python_3_8_unsupported_error will be removed from the codebase and tests should continue to pass.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@amazimbe amazimbe self-assigned this Feb 18, 2025
@amazimbe amazimbe force-pushed the amazimbe/python3.8-deprecation-ff-cleanup branch from 17798d9 to 958d1d2 Compare February 19, 2025 11:07
@amazimbe amazimbe marked this pull request as ready for review February 19, 2025 11:08
@amazimbe amazimbe requested a review from a team as a code owner February 19, 2025 11:08
@amazimbe amazimbe changed the title Remove python 3.8 deprecation FFs and cleanup tests Remove python 3.8 deprecation / unsupported FFs and cleanup tests Feb 19, 2025
@amazimbe amazimbe force-pushed the amazimbe/python3.8-deprecation-ff-cleanup branch from 958d1d2 to ea3d1b4 Compare February 19, 2025 11:39
@amazimbe amazimbe merged commit 3679632 into main Feb 19, 2025
64 checks passed
@amazimbe amazimbe deleted the amazimbe/python3.8-deprecation-ff-cleanup branch February 19, 2025 12:02
dmitris pushed a commit to dmitris/dependabot-core that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants