Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Nuget Runner] Validate that we preserve line endings in Nuget dependency updates #11629

Merged

Conversation

Penguinwizzard
Copy link
Contributor

What are you trying to accomplish?

This adds stronger testing around End-of-Line (EoL) preservation to the new RunWorker functionality, and adds a second-pass EoL normalization run that should correct any cases we miss in the future.

Anything you want to highlight for special attention from reviewers?

The existing tests are made into Theories that run with different line endings and validate that they're preserved across the dependency update process.

How will you know you've accomplished your goal?

This was implemented using TDD, although the tests passed before the functionality changes were done.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@Penguinwizzard Penguinwizzard requested a review from a team as a code owner February 18, 2025 22:49
@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Feb 18, 2025
@Penguinwizzard Penguinwizzard changed the title [New Nuget Runner] Validate that we preserve case in Nuget dependency updates [New Nuget Runner] Validate that we preserve line endings in Nuget dependency updates Feb 19, 2025
@brettfo brettfo force-pushed the user/demorri/runner_preserve_case branch 2 times, most recently from 82cba4b to 8353cd5 Compare February 19, 2025 23:03
@randhircs randhircs force-pushed the user/demorri/runner_preserve_case branch from 8353cd5 to 80b92cd Compare February 20, 2025 14:16
@randhircs randhircs merged commit d0d067c into dependabot:main Feb 20, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants