-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize Package Release Fetching Format and Implement JSON API for Python #11630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57d5e34
to
1af2e14
Compare
28d081f
to
3917c68
Compare
python/lib/dependabot/python/update_checker/latest_version_finder.rb
Fixed
Show resolved
Hide resolved
python/lib/dependabot/python/update_checker/latest_version_finder.rb
Fixed
Show resolved
Hide resolved
python/lib/dependabot/python/update_checker/latest_version_finder.rb
Fixed
Show resolved
Hide resolved
python/lib/dependabot/python/package/package_registry_finder.rb
Dismissed
Show dismissed
Hide dismissed
…ormat create a generic package release array format that can be applied accross ecosystems
optimize the code and reduce duplications
4ca6428
to
1ec0c11
Compare
randhircs
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve it, Tests cases are updated and I assume we have added all the test cases in terms of validating/verifying json response date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This PR standardizes the format for package release fetching by introducing a common structure (
PackageRelease
,PackageLanguage
,PackageDetails
) that ensures consistency across ecosystems. This standardized format will be applicable to other package managers in the future.As the first step, it applies this standardized fetching format to Python, implementing JSON API fetching as the primary method while keeping HTML fallback support for backward compatibility.
The JSON API fetching is behind a feature flag to ensure a controlled rollout and allow for further validation before full adoption.
Switching to JSON API fetching provides the following benefits:
What does this PR do?
PackageRelease
,PackageLanguage
, andPackageDetails
as common data structures.{url}/pypi
) behind a feature flag, allowing for controlled testing and gradual rollout.Anything you want to highlight for special attention from reviewers?
PackageRelease
,PackageLanguage
,PackageDetails
) is correctly applied to Python.How will you know you've accomplished your goal?
PackageRelease
,PackageLanguage
,PackageDetails
).Checklist ✅