Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bun image strategy to push the Bun updater image #11648

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

markhallen
Copy link
Contributor

@markhallen markhallen commented Feb 20, 2025

What are you trying to accomplish?

When running the Bun updater, it is matching to the "bundler" image as the Bun image has not been registered correctly.

Part of https://github.com/github/dependabot-updates/issues/7990

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

We should start to see the Bun image being pushed to the registry and used.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@markhallen markhallen requested a review from a team as a code owner February 20, 2025 11:01
@markhallen markhallen requested a review from Copilot February 20, 2025 11:02

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This pull request adds a Bun image strategy to ensure the Bun updater correctly uses its own image rather than defaulting to the bundler image. It also reorganizes the ErrorHandler type alias definition within the Bun module and updates the workflow configuration to include the Bun ecosystem for image pushes.

  • Moved the ErrorHandler type alias from the top of the file into the Bun module.
  • Added a new CI workflow matrix entry to push the Bun image.

Reviewed Changes

File Description
bun/lib/dependabot/bun.rb Relocated the ErrorHandler type alias inside the Bun module for improved scoping.
.github/workflows/images-latest.yml Added the Bun ecosystem entry to the workflow matrix for pushing the Bun updater image.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

bun/lib/dependabot/bun.rb:127

  • The relocation of the ErrorHandler type alias into the Bun module might affect any external references expecting it at the previous scope. Please verify that all usages of ErrorHandler are updated accordingly.
ErrorHandler = T.type_alias do

.github/workflows/images-latest.yml:37

  • Consider adding tests or validations for the new Bun image strategy to ensure that the workflow correctly pushes the Bun image as intended.
- { name: bun, ecosystem: bun }

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

@markhallen markhallen merged commit 6bd0d7b into main Feb 20, 2025
58 checks passed
@markhallen markhallen deleted the markhallen/add-bun-image-strategy branch February 20, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants