report specific missing file during discovery #11654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
commented
Feb 20, 2025
| @@ -795,7 +795,7 @@ internal static async Task<ImmutableArray<string>> GetTargetFrameworkValuesFromP | |||
| ); | |||
| return (exitCode, stdOut, stdErr); | |||
| }); | |||
| ThrowOnUnauthenticatedFeed(stdOut); | |||
| ThrowOnError(stdOut); | |||
There was a problem hiding this comment.
This function is a wrapper around ThrowOnUnauthenticatedFeed as well as a bunch of others, including ThrowOnMissingFile.
sebasgomez238
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a required project, props, or targets file is missing or if the casing doesn't match and MSBuild on Linux can't resolve it, report the specific file.
Previously a missing file would cause an error in discovery and nothing would be returned and the empty dependency file set turned into a
dependency_file_not_foundreporting that no.csprojfiles were found.That's not entirely correct so now that specific file is captured and reported. The end result for the user is the same, but this will make log classification easier.