Capture errors on deps.get in Hex ecosystem #11661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was also bug that encoded errors, but didn't actually pass them back. This should resolve the current issues while reporting actual errors. |
TylerWitt
force-pushed
the
hex/capture-more-errors
branch
from
53b71e1 to
d980d83
Compare
|
Thanks @TylerWitt I'll deploy this tomorrow. |
amazimbe
force-pushed
the
hex/capture-more-errors
branch
from
d980d83 to
2106d79
Compare
amazimbe
approved these changes
Feb 25, 2025
Since all errors are expected to be base encoded, we need to capture them and encode them, which was previously not happening.
The error was encoded but never used.
amazimbe
force-pushed
the
hex/capture-more-errors
branch
from
2106d79 to
b74eab4
Compare
dmitris
pushed a commit
to dmitris/dependabot-core
that referenced
this pull request
Feb 26, 2025
* Capture errors on deps.get in Hex ecosystem Since all errors are expected to be base encoded, we need to capture them and encode them, which was previously not happening. * Use the encoded error The error was encoded but never used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Since all errors are expected to be encoded, we need to capture them and encode them, which was previously not happening.
Anything you want to highlight for special attention from reviewers?
How will you know you've accomplished your goal?
Checklist