Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support images wrapped in quotes #11669

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Support images wrapped in quotes #11669

merged 1 commit into from
Feb 24, 2025

Conversation

robaiken
Copy link
Contributor

@robaiken robaiken commented Feb 24, 2025 •
edited
Loading

What are you trying to accomplish?

Images with quotes are not being updated and resulting in a no change error. This PR adds support for images wrapped in quotes.

Thanks to @Bert-R #390 (comment) and @Aaron-Ritter #390 (comment) for reporting this issue

How will you know you've accomplished your goal?

Dependabot will now be able to update images wrapped in quotes

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@robaiken robaiken requested a review from a team as a code owner February 24, 2025 11:28
@github-actions github-actions bot added the L: docker:compose Docker Compose label Feb 24, 2025
@robaiken robaiken mentioned this pull request Feb 24, 2025
Closed
markhallen
markhallen approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@markhallen markhallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robaiken robaiken force-pushed the robaiken/allow-updates-to-images-with-quotes branch from 8c28644 to 998d045 Compare February 24, 2025 12:15
@robaiken robaiken merged commit c17984a into main Feb 24, 2025
78 of 80 checks passed
@robaiken robaiken deleted the robaiken/allow-updates-to-images-with-quotes branch February 24, 2025 12:45
dmitris pushed a commit to dmitris/dependabot-core that referenced this pull request Feb 26, 2025
@robaiken @dmitris
Support images wrapped in quotes (dependabot#11669)
f643bc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markhallen markhallen markhallen approved these changes

Assignees
No one assigned
Labels
L: docker:compose Docker Compose
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robaiken @markhallen