Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Generic Cooldown Filtering and Enable for Python Package Manager #11693

Merged
merged 16 commits into from
Mar 3, 2025

Conversation

kbukum1
Copy link
Contributor

@kbukum1 kbukum1 commented Feb 27, 2025

What are you trying to accomplish?

This PR introduces a generic cooldown filtering mechanism that can be applied to all ecosystems when enabled. Initially, this feature is enabled for the Python package managers to regulate update frequency and prevent unnecessary frequent version bumps.

The cooldown mechanism ensures that only versions that have surpassed the configured cooldown period are considered when determining the latest available versions.

Anything you want to highlight for special attention from reviewers?

  • The implementation is generic, allowing other ecosystems to opt into cooldown filtering in the future.
  • Currently, it is enabled only for Python (PIP).
  • Cooldown filtering is applied during version retrieval, ensuring updates follow cooldown rules.
  • This implementation aligns with existing cooldown logic used elsewhere in Dependabot.

How will you know you've accomplished your goal?

  • Versions that do not meet the cooldown criteria are correctly filtered out.
  • The latest version selection process adheres to the configured cooldown settings.
  • Unit tests confirm that cooldown filtering works as expected across different update scenarios.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@kbukum1 kbukum1 marked this pull request as ready for review March 3, 2025 19:57
@kbukum1 kbukum1 requested a review from a team as a code owner March 3, 2025 19:57
Copy link
Contributor

@thavaahariharangit thavaahariharangit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kbukum1 kbukum1 merged commit 8d6e12c into main Mar 3, 2025
153 of 161 checks passed
@kbukum1 kbukum1 deleted the kamil/add_cooldown_to_configuration branch March 3, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants