Simplify the "version already exists" check by using RubyGems v2 API #11712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deivid-rodriguez can we safely assume this v2 endpoint is a stable API? |
JamieMagee
approved these changes
Mar 3, 2025
The v2 API has endpoints specific to each version: https://guides.rubygems.org/rubygems-org-api-v2/ Benefits: 1. Less data gets returned over the wire Compare: * https://rubygems.org/api/v1/versions/dependabot-omnibus.json * https://rubygems.org/api/v2/rubygems/dependabot-omnibus/versions/0.299.1.json 2. Less brittle since we no longer parse the `response.body` 3. Faster since we only check `response.code` I verified that sending a non-existent version returns a `404`: https://rubygems.org/api/v2/rubygems/dependabot-omnibus/versions/0.7.1.json
jeffwidman
force-pushed
the
use-v2-api-for-simpler-and-faster-existence-check
branch
from
08f8ddb to
89c603a
Compare
|
Yes, yes, we should keep this public and documented API working 😅. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v2 API added endpoints specific for a specific version of a gem: https://guides.rubygems.org/rubygems-org-api-v2/
Benefits:
Compare:
response.bodyresponse.codeI verified that sending a non-existent version returns a
404: https://rubygems.org/api/v2/rubygems/dependabot-omnibus/versions/0.7.1.json