Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade Rust Docker image from 1.85.0-bookworm to 1.84.0-bookworm to restore missing dependencies #11738

Merged

Conversation

kbukum1
Copy link
Contributor

@kbukum1 kbukum1 commented Mar 5, 2025

What are you trying to accomplish?

Downgrading the Rust base image from rust:1.85.0-bookworm to rust:1.84.0-bookworm to fix missing dependencies in the Cargo ecosystem.

Why?

The rust:1.85.0-bookworm Docker image is missing required layers, leading to issues where cargo is not found in the container environment. This has been confirmed by reverting locally and testing cargo commands successfully.

Issue Link: dependabot-core/issues/11737
Sentry Issue: DELTAFORCE-12XK

Anything you want to highlight for special attention from reviewers?

  • This downgrade is a temporary fix to restore functionality.
  • Further investigation may be needed to determine why rust:1.85.0-bookworm is missing essential dependencies.
  • If a better long-term solution is found, we may consider upgrading in the future.

How will you know you've accomplished your goal?

  • Running cargo commands inside the container should work as expected.
  • CI/CD tests should pass without any dependency-related failures.
  • The error reported in the linked issue should no longer occur.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@kbukum1 kbukum1 marked this pull request as ready for review March 5, 2025 18:45
@kbukum1 kbukum1 requested a review from a team as a code owner March 5, 2025 18:45
@github-actions github-actions bot added the L: rust:cargo Rust crates via cargo label Mar 5, 2025
@kbukum1 kbukum1 merged commit e45c736 into main Mar 5, 2025
60 of 63 checks passed
@kbukum1 kbukum1 deleted the kamil/downgrade-docker-rust-bookworm-fix-env-build-issue branch March 5, 2025 19:04
robaiken added a commit that referenced this pull request Mar 6, 2025
robaiken added a commit that referenced this pull request Mar 6, 2025
robaiken added a commit that referenced this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: rust:cargo Rust crates via cargo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants