Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing cooldown options into Python Latest Version Finder #11743

Merged

Conversation

kbukum1
Copy link
Contributor

@kbukum1 kbukum1 commented Mar 5, 2025

What are you trying to accomplish?

This PR fixes an issue where cooldown options were not being correctly passed into the latest version finder. This ensures that the version resolution process properly respects cooldown settings, preventing unnecessary updates from being suggested too soon.

Anything you want to highlight for special attention from reviewers?

  • The fix ensures that cooldown settings are correctly included in the version-finding logic.
  • Let me know if there are edge cases I might have missed.

How will you know you've accomplished your goal?

  • Verified that cooldown settings are correctly applied when resolving versions.
  • Tests cover the expected cooldown behavior to prevent early dependency updates.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@kbukum1 kbukum1 force-pushed the kamil/fix-passing-cooldown-to-python-latest-version-finder branch from b4c6a82 to afc9153 Compare March 5, 2025 23:37
@kbukum1 kbukum1 marked this pull request as ready for review March 6, 2025 02:25
@kbukum1 kbukum1 requested a review from a team as a code owner March 6, 2025 02:25
@kbukum1 kbukum1 merged commit bf01b3d into main Mar 6, 2025
68 checks passed
@kbukum1 kbukum1 deleted the kamil/fix-passing-cooldown-to-python-latest-version-finder branch March 6, 2025 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants