Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/Update Specs for Job & Fix Dry-Run to Pass Cooldown Through Env Variables #11753

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

kbukum1
Copy link
Contributor

@kbukum1 kbukum1 commented Mar 6, 2025

What are you trying to accomplish?

This PR improves test coverage by adding and updating specs for Job, ensuring that cooldown functionality is properly tested. Additionally, it fixes an issue where the dry-run mode was not passing cooldown settings through environment variables.

These changes help ensure that cooldown settings are correctly parsed, applied, and tested across different update scenarios.

Anything you want to highlight for special attention from reviewers?

  • Updated spec coverage for Job, focusing on cooldown attributes and parsing.
  • Fixed the dry-run functionality to correctly pass cooldown settings via environment variables.
  • Ensured that cooldown behavior is consistent when applied in different cases.

How will you know you've accomplished your goal?

  • Running the full test suite should confirm that cooldown settings are handled correctly in both normal and dry-run modes.
  • The dry-run execution should now correctly reflect cooldown values when passed through environment variables.
  • The new and updated test cases should cover all expected cooldown behaviors.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

add/update specs for job
fix dry-run to pass cooldown through env variables
@kbukum1 kbukum1 marked this pull request as ready for review March 6, 2025 20:09
@kbukum1 kbukum1 requested a review from a team as a code owner March 6, 2025 20:09
@kbukum1 kbukum1 merged commit bd9e70e into main Mar 6, 2025
131 of 134 checks passed
@kbukum1 kbukum1 deleted the kamil/fix-naming-for-major-minor-path-days branch March 6, 2025 21:03
jonabc pushed a commit that referenced this pull request Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants