Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cooldown parameter from update checker for security updates #11758

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

kbukum1
Copy link
Contributor

@kbukum1 kbukum1 commented Mar 6, 2025

What are you trying to accomplish?

Currently, we do not support cooldown for security updates. This change removes the cooldown parameter from the update checker for security updates to align with this decision.

This prevents unnecessary parameter passing and ensures security updates are handled correctly without cooldown delays.

Anything you want to highlight for special attention from reviewers?

  • This change affects only security updates, general update logic remains unchanged.
  • No functional impact on non-security updates.

How will you know you've accomplished your goal?

  • Security updates will no longer receive a cooldown parameter.
  • The behavior of security updates remains consistent with the intended functionality.
  • Tests confirm that security updates continue to be processed correctly.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@kbukum1 kbukum1 marked this pull request as ready for review March 6, 2025 23:22
@kbukum1 kbukum1 requested a review from a team as a code owner March 6, 2025 23:22
@kbukum1 kbukum1 requested review from honeyankit, abdulapopoola and robaiken and removed request for robaiken March 6, 2025 23:47
@@ -238,7 +238,7 @@ def update_checker_for(dependency)
security_advisories: job.security_advisories_for(dependency),
raise_on_ignored: true, # always true for security updates
requirements_update_strategy: job.requirements_update_strategy,
update_cooldown: job.cooldown,
# update_cooldown: job.cooldown, Currently not supported for security updates
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for the contextual code comment to make it clear that the omission is intentional

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the review.

@kbukum1 kbukum1 merged commit 57277f9 into main Mar 7, 2025
154 of 157 checks passed
@kbukum1 kbukum1 deleted the kamil/allow-cooldown-for-only-version-updates branch March 7, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants