add simple title, commit message, and body text generation #11763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
force-pushed
the
dev/brettfo/nuget-pr-text
branch
from
82af66e to
d7e3974
Compare
ryanbrandenburg
approved these changes
Mar 7, 2025
| .Where(d => d.Version is not null) | ||
| .Select(d => d.Version!) | ||
| .OrderBy(d => NuGetVersion.Parse(d)) | ||
| .ToArray() |
There was a problem hiding this comment.
q: Is there a reason we need to force evaluation with .ToArray() here or is it just habit?
There was a problem hiding this comment.
It's purely so I can see the result in the debugger without expanding the "Results" element. Similar reason I set "var title = ..." then immediately "return title;"; it's so I have handy breakpoint locations and can immediately see the value.
ryanbrandenburg
approved these changes
Mar 10, 2025
sachin-sandhu
force-pushed
the
dev/brettfo/nuget-pr-text
branch
from
d7e3974 to
ad52297
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are for the end-to-end updater and this code is not live.
Adds simple PR title generation of the shape:
In a more complicated scenario where multiple versions were updated for multiple packages the text will look like:
The same text is used for all three generated fields: PR title, body, and commit message.
The other tests were modified to always report static text for these fields so that changes to the new text generation won't cause a bunch of other tests to fail and require a lot of churn.