Fix NilClass
error in format_version_releases
for Python package details fetcher
#11789
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This PR fixes an issue where
fetch_from_json_registry
inPackageDetailsFetcher
could returnnil
, leading to a Sorbet type validation error:This error occurs when the registry response is unexpectedly empty or missing the
releases
key. The fix ensures thatfetch_from_json_registry
handles this case gracefully by providing a default empty hash ({}
) if the response isnil
.What issues does this affect or fix?
Fixes:
Anything you want to highlight for special attention from reviewers?
fetch_from_json_registry
returnsnil
, the method does not break due to unexpectedNilClass
values.How will you know you've accomplished your goal?
fetch_from_json_registry
no longer causes Sorbet type validation errors.releases_json
is missing from the registry response.Checklist