Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toml-rb to v 4.0 #11796

Merged
merged 7 commits into from
Mar 13, 2025
Merged

Update toml-rb to v 4.0 #11796

merged 7 commits into from
Mar 13, 2025

Conversation

markhallen
Copy link
Contributor

@markhallen markhallen commented Mar 12, 2025

What are you trying to accomplish?

We want to fully support dependency groups in uv and need to update the toml-rb gem to version 4.

We had issues handling uv dependencies when the dependency-group in the pyproject.toml consited of a mixture of objects and strings. eg #10478 (comment)

Thank you @emancu for the rapid fix emancu/toml-rb#152

Also, closes #10847

Anything you want to highlight for special attention from reviewers?

cc @edgarrmondragon

How will you know you've accomplished your goal?

We tested the dry run with meltano/sdk: ./bin/dry-run.rb uv meltano/sdk. We encountered the error specified before updating the gem and it completed successfully after updating the gem.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@markhallen markhallen requested a review from a team as a code owner March 12, 2025 13:34
@markhallen markhallen force-pushed the markhallen/update-toml-rb-gem branch from ee353a7 to d97692b Compare March 12, 2025 13:41
Copy link
Contributor

@kbukum1 kbukum1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markhallen markhallen merged commit 1cc8b18 into main Mar 13, 2025
131 of 134 checks passed
@markhallen markhallen deleted the markhallen/update-toml-rb-gem branch March 13, 2025 09:47
@MusicalNinjaDad
Copy link

Thank you for this ... It's fixed the error and working great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants