[Feature] Standardize uv Package Fetcher, Extend Latest Version Finder, and Enable Cooldown Filtering via Feature Flag
#11804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implement generic latest version finder pass cooldown parameter
kbukum1
commented
Mar 12, 2025
| extend T::Sig | ||
|
|
||
| require_relative "index_finder" |
There was a problem hiding this comment.
Review: Uses generic Dependabot::Package::PackageLatestVersionFinder similar to as how python is using.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
kbukum1
commented
Mar 12, 2025
| end | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
Review: Fetcher is duplication from python ecosystem. Except package manager being uveverything is same aspip` ecosystem. We do use same api to get releases for dependencies.
kbukum1
commented
Mar 12, 2025
| @raise_on_ignored = raise_on_ignored | ||
| @security_advisories = security_advisories | ||
| end | ||
|
|
||
| def latest_resolvable_version | ||
| latest_version_finder.latest_version(python_version: language_version_manager.python_version) | ||
| latest_version_finder.latest_version(language_version: language_version_manager.python_version) | ||
| end |
There was a problem hiding this comment.
Review Tip: In generic method instead of python we accept language_version since that is used across ecosystem.
kbukum1
commented
Mar 12, 2025
| dependency: dependency, | ||
| dependency_files: dependency_files, | ||
| credentials: credentials | ||
| ).fetch | ||
| end |
There was a problem hiding this comment.
Review Tip: We are fetching files in standard format and returning that to generic latest version finder so it can use the standard format filter out version properly.
abdulapopoola
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This PR enhances the
uvecosystem by:package_release_detailsformat, ensuring compatibility with cooldown filtering.enable_cooldown_for_uv) to:Completed Tasks:
✅ [Task] Standardize
uvPackage Fetcher to Support Generic Package Release Details✅ [Task] Extend
uvEcosystem Latest Version Finder to Use Generic Latest Version Finder✅ [Task] Use
enable_cooldown_for_uvto enable fetching from JSON API✅ [Task] Use
enable_cooldown_for_uvto Enable Cooldown FilteringThese changes improve dependency resolution for
uv, ensure consistent package data retrieval, and allow for cooldown-based filtering using structured release details.What issues does this affect or fix?
uvpackage fetcher now returns structured package release details, including release dates, which are required for cooldown filtering.enable_cooldown_for_uvallows incremental activation of:Anything you want to highlight for special attention from reviewers?
enable_cooldown_for_uvhas been added to:How will you know you've accomplished your goal?
uvpackage fetcher correctly retrieves structured package release details, including release dates.uvlatest version finder inherits from the generic latest version finder and applies cooldown filtering.enable_cooldown_for_uvcorrectly controls:Checklist