Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Spaces Toolbar #385

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Support for Spaces Toolbar #385

merged 1 commit into from
Oct 4, 2022

Conversation

devmount
Copy link
Owner

@devmount devmount commented Oct 4, 2022

Description of the Change

This change adds a ThirdStats button to the Spaces Toolbar of Thunderbird:

image
image

When clicking the button, the stats page opens or the already opened tab gets active.

Benefits

Easier access to the stats page

Applicable Issues

Implements #382

@devmount devmount merged commit f420ec8 into master Oct 4, 2022
@devmount devmount deleted the spaces-toolbar branch October 4, 2022 15:20
@ovari
Copy link
Contributor

ovari commented Oct 4, 2022

Haven't been able to test as it is not yet in ATN. Does it play nicely with CardBook which also uses the Spaces Toolbar?

cc @CardBook

@devmount
Copy link
Owner Author

devmount commented Oct 5, 2022

You can always test the unreleased changes by downloading and installing the latest nightly build:

https://third-stats.cdn.devmount.com/

It simply adds a button to the toolbar which I assume CardBook does as well. But let me know if you encounter any bugs here.

@ovari
Copy link
Contributor

ovari commented Oct 5, 2022

  1. It seems that order of the CardBook and ThirdStats is shown in the order that the add-ons are added.

Is it possible to always show ThirdStats after CardBook?

Spaces Toolbar

ThirdStats always shows after CardBook when the Hide Spaces Toolbar is selected.

  1. Should ThirdStats icon in the Spaces Toolbar be grey (i.e. no color)?

What do you think?

Thank you

@devmount
Copy link
Owner Author

devmount commented Oct 5, 2022

First: Thank you for testing this and giving valuable feedback! 👏🏻

  1. I don't see a way to manipulate the order of spaces toolbar buttons with the curren API. I created a topic for this.
  2. On the one hand, I like the icon to be consistent in all places of Thunderbird (popup, favicon, etc), on the other hand, a gray icon would integrate much better at this place. I'll test a gray icon and let you know, when you can test a corresponding nightly build as well.

@devmount
Copy link
Owner Author

@ovari

  1. I didn't get an answer yet. I asked in the UX group too.
  2. I implemented your suggestion and it looks much better imo. It's released now with version 1.10.0

@ovari
Copy link
Contributor

ovari commented Mar 30, 2023

Seems to still be not grey icon.

image

@devmount
Copy link
Owner Author

devmount commented Mar 30, 2023

Interesting, it should look like this

image
image

Since you already installed a nightly version before, I suspect this to be a cache thing. Although I haven't had this issue when upgrading to 1.10 🤔 Maybe reinstalling ThirdStats helps?

@ovari
Copy link
Contributor

ovari commented Mar 30, 2023

Since you already installed a nightly version before, I suspect this to be a cache thing. Although I haven't had this issue when upgrading to 1.10 thinking Maybe reinstalling ThirdStats helps?

It was a fresh install.

@devmount
Copy link
Owner Author

Well, I really can't reproduce this. I even tried with Betterbird... sorry

@ovari
Copy link
Contributor

ovari commented Apr 10, 2023

Thanks for trying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants