Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some events want the menu to link outside #76

Closed
mattstratton opened this issue Mar 7, 2016 · 4 comments
Closed

Some events want the menu to link outside #76

mattstratton opened this issue Mar 7, 2016 · 4 comments
Assignees
@mattstratton
Milestone
Future Enhancements

Comments

@mattstratton
Copy link
Member

Again, see DC as an example. Should be able to override the destination of menu items such as "register"
@mattstratton mattstratton added this to the Future Enhancements milestone Apr 11, 2016
@bridgetkromhout
Copy link
Collaborator

As a temporary measure, I'd imagine we could just have a placeholder local page that contains a redirect.

@mattstratton
Copy link
Member Author

Totally. This isn't really that big of a deal to implement - we would probably end up just restructuring the navigationelements section of the data file to allow an optional additional value which would be a URL override.

@mattstratton mattstratton self-assigned this Apr 13, 2016
mattstratton added a commit that referenced this issue Apr 13, 2016
@mattstratton
Merge pull request #122 from devopsdays/mattstratton/create-nav-ovveride
a48a5c0 
Added offsite nav links. Fixes #76
@davidasnider
Copy link
Contributor

This worked great for me, FYI. However the change you reference wasn't reflected in the repository. themes/devopsdays-legacy/layouts/event/single.html... I had to update it to match what is in 5559e01. The problem is, now I'm afraid to commit it, because I don't 'own' that file. Suggestions?

@mattstratton
Copy link
Member Author

Oh I broke that. I'll fix it in a jiffy.

mattstratton added a commit that referenced this issue Apr 15, 2016
@mattstratton
Fix event header to re-implement offsite links
5df79fc 
When I refactored out the event_header partial, I didn't bring over the offsite link capability. This commit fixes this. The commit that broke it was dfc9062. This was identified in #76 by @davidasnider.
@mattstratton mattstratton mentioned this issue Apr 15, 2016
Merged
benjohnson77 pushed a commit to benjohnson77/devopsdays-web that referenced this issue May 22, 2016
@mattstratton
Added offsite nav links. Fixes devopsdays#76
99e60b4 
This fundamentally changes the structure of the navigation links in the event configuration file. See the sample data file for an example. The "old" style data file is still functional for backwards compatibility.


Former-commit-id: 5559e01
benjohnson77 pushed a commit to benjohnson77/devopsdays-web that referenced this issue May 22, 2016
@mattstratton
Merge pull request devopsdays#122 from devopsdays/mattstratton/create…
5c639f6 
…-nav-ovveride

Added offsite nav links. Fixes devopsdays#76

Former-commit-id: a48a5c0
benjohnson77 pushed a commit to benjohnson77/devopsdays-web that referenced this issue May 22, 2016
@mattstratton
Fix event header to re-implement offsite links
86df9b0 
When I refactored out the event_header partial, I didn't bring over the offsite link capability. This commit fixes this. The commit that broke it was dfc9062. This was identified in devopsdays#76 by @davidasnider.


Former-commit-id: 5df79fc
benjohnson77 pushed a commit to benjohnson77/devopsdays-web that referenced this issue May 22, 2016
@mattstratton
Merge pull request devopsdays#149 from devopsdays/mattstratton/fix-ev…
c872d84 
…ent-header-menu

Fix event header to re-implement offsite links. Fixes devopsdays#76 (again)

Former-commit-id: 45780e5
yvovandoorn pushed a commit that referenced this issue May 22, 2016
@mattstratton
Added offsite nav links. Fixes #76
2b44fd0 
This fundamentally changes the structure of the navigation links in the event configuration file. See the sample data file for an example. The "old" style data file is still functional for backwards compatibility.
yvovandoorn pushed a commit that referenced this issue May 22, 2016
@mattstratton
Merge pull request #122 from devopsdays/mattstratton/create-nav-ovveride
1e36a06 
Added offsite nav links. Fixes #76
yvovandoorn pushed a commit that referenced this issue May 22, 2016
@mattstratton
Fix event header to re-implement offsite links
b809fe8 
When I refactored out the event_header partial, I didn't bring over the offsite link capability. This commit fixes this. The commit that broke it was dfc9062. This was identified in #76 by @davidasnider.
yvovandoorn pushed a commit that referenced this issue May 22, 2016
@mattstratton
Merge pull request #149 from devopsdays/mattstratton/fix-event-header…
d49b564 
…-menu

Fix event header to re-implement offsite links. Fixes #76 (again)
yvovandoorn pushed a commit that referenced this issue May 22, 2016
@mattstratton
Added offsite nav links. Fixes #76
ab72ffd 
This fundamentally changes the structure of the navigation links in the event configuration file. See the sample data file for an example. The "old" style data file is still functional for backwards compatibility.


Former-commit-id: 5559e01
yvovandoorn pushed a commit that referenced this issue May 22, 2016
@mattstratton
Added offsite nav links. Fixes #76
75caf51 
This fundamentally changes the structure of the navigation links in the event configuration file. See the sample data file for an example. The "old" style data file is still functional for backwards compatibility.
yvovandoorn pushed a commit that referenced this issue May 22, 2016
@mattstratton
Merge pull request #122 from devopsdays/mattstratton/create-nav-ovveride
874f5c0 
Added offsite nav links. Fixes #76

Former-commit-id: a48a5c0
yvovandoorn pushed a commit that referenced this issue May 22, 2016
@mattstratton
Merge pull request #122 from devopsdays/mattstratton/create-nav-ovveride
89e2ef5 
Added offsite nav links. Fixes #76
yvovandoorn pushed a commit that referenced this issue May 22, 2016
@mattstratton
Fix event header to re-implement offsite links
728d5fc 
When I refactored out the event_header partial, I didn't bring over the offsite link capability. This commit fixes this. The commit that broke it was dfc9062. This was identified in #76 by @davidasnider.


Former-commit-id: 5df79fc
yvovandoorn pushed a commit that referenced this issue May 22, 2016
@mattstratton
Fix event header to re-implement offsite links
6f491f0 
When I refactored out the event_header partial, I didn't bring over the offsite link capability. This commit fixes this. The commit that broke it was dfc9062. This was identified in #76 by @davidasnider.
yvovandoorn pushed a commit that referenced this issue May 22, 2016
@mattstratton
Merge pull request #149 from devopsdays/mattstratton/fix-event-header…
43db0ba 
…-menu

Fix event header to re-implement offsite links. Fixes #76 (again)

Former-commit-id: 45780e5
yvovandoorn pushed a commit that referenced this issue May 22, 2016
@mattstratton
Merge pull request #149 from devopsdays/mattstratton/fix-event-header…
c081395 
…-menu

Fix event header to re-implement offsite links. Fixes #76 (again)
yvovandoorn pushed a commit that referenced this issue May 29, 2016
@mattstratton
Added offsite nav links. Fixes #76
dd377be 
This fundamentally changes the structure of the navigation links in the event configuration file. See the sample data file for an example. The "old" style data file is still functional for backwards compatibility.


Former-commit-id: 5559e01
yvovandoorn pushed a commit that referenced this issue May 29, 2016
@mattstratton
Added offsite nav links. Fixes #76
6c43adf 
This fundamentally changes the structure of the navigation links in the event configuration file. See the sample data file for an example. The "old" style data file is still functional for backwards compatibility.
yvovandoorn pushed a commit that referenced this issue May 29, 2016
@mattstratton
Merge pull request #122 from devopsdays/mattstratton/create-nav-ovveride
1d6d5b8 
Added offsite nav links. Fixes #76

Former-commit-id: a48a5c0
yvovandoorn pushed a commit that referenced this issue May 29, 2016
@mattstratton
Merge pull request #122 from devopsdays/mattstratton/create-nav-ovveride
acc5e8e 
Added offsite nav links. Fixes #76
yvovandoorn pushed a commit that referenced this issue May 29, 2016
@mattstratton
Fix event header to re-implement offsite links
d8afdb4 
When I refactored out the event_header partial, I didn't bring over the offsite link capability. This commit fixes this. The commit that broke it was dfc9062. This was identified in #76 by @davidasnider.


Former-commit-id: 5df79fc
yvovandoorn pushed a commit that referenced this issue May 29, 2016
@mattstratton
Fix event header to re-implement offsite links
32cf7a7 
When I refactored out the event_header partial, I didn't bring over the offsite link capability. This commit fixes this. The commit that broke it was dfc9062. This was identified in #76 by @davidasnider.
yvovandoorn pushed a commit that referenced this issue May 29, 2016
@mattstratton
Merge pull request #149 from devopsdays/mattstratton/fix-event-header…
e22bf4f 
…-menu

Fix event header to re-implement offsite links. Fixes #76 (again)

Former-commit-id: 45780e5
yvovandoorn pushed a commit that referenced this issue May 29, 2016
@mattstratton
Merge pull request #149 from devopsdays/mattstratton/fix-event-header…
385ca69 
…-menu

Fix event header to re-implement offsite links. Fixes #76 (again)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattstratton mattstratton

Labels
None yet
Projects
None yet
Milestone
Future Enhancements
Development

No branches or pull requests
3 participants
@mattstratton @bridgetkromhout @davidasnider