Fixed bug caused by calling Poison.encode! on an empty request body #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Togglex.json_request
, the argumentbody
is encoded to JSON using thePoison.encode!
function. The default value for this argument is an empty string (""
).Calling
Poison.encode!
on an empty string returns"\"\""
. In the past, Toggl's servers would process requests issued with this request body without issue. However, sometime within the last few months, the behavior of the API changed. Now when a request is submitted to Toggl with this value in the request body, Toggl returns an HTML page with an "invalid request" message.This results in a
:connect_timeout
exception being raised (in version 0.2.0 of Togglex) when calling certain functions, such asTogglex.Reports.summary
. (In version 0.1.0, a "Unexpected token" exception is raised.)This pull request adds a check in the
Togglex.json_request
function that skips the call toPoison.encode!
ifbody
is empty.