Pass the right hand side to JoinTo
#1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a refactoring in preparation for ad-hoc join clauses. I'm imagining the API being roughly `lhs.inner_join(rhs.on(on_clause))`, which will mean we will have a struct containing the rhs and the on clause. The `JoinTo` impl for this struct will need to just destructure it and return those pieces, so this sets up the trait changes for all existing implementations. I had to bump clippy as part of this change, as it hits a rustc bug that was fixed on more recent nightlies. However, I couldn't bump to the *latest* clippy, as recent nightlies are broken for us due to rust-lang/rust#43153
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring in preparation for ad-hoc join clauses. I'm
imagining the API being roughly
lhs.inner_join(rhs.on(on_clause)),which will mean we will have a struct containing the rhs and the on
clause. The
JoinToimpl for this struct will need to just destructureit and return those pieces, so this sets up the trait changes for all
existing implementations.
I had to bump clippy as part of this change, as it hits a rustc bug that
was fixed on more recent nightlies. However, I couldn't bump to the
latest clippy, as recent nightlies are broken for us due to
rust-lang/rust#43153