Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify: rewrite bitxnor on booleans to equal #8594

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kroening
Copy link
Member

This adds the rewrite a xnor b --> a = b for booleans a, b to the simplifier.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.47%. Comparing base (159af34) to head (c04a588).

Files with missing lines Patch % Lines
src/util/simplify_expr_int.cpp 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8594      +/-   ##
===========================================
- Coverage    79.57%   79.47%   -0.10%     
===========================================
  Files         1733     1733              
  Lines       197826   198069     +243     
  Branches     18197    17968     -229     
===========================================
  Hits        157421   157421              
- Misses       40405    40648     +243     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +699 to +700
else if(expr.id() == ID_bitxnor)
new_expr.id(ID_equal);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below we call simplify_boolean on the resulting expression, which won't know how to simplify equality. We'll have to change the call below to simplify_node.

This adds the rewrite (a xnor b) --> (a = b) for booleans a, b to the
simplifier.
@kroening kroening marked this pull request as ready for review February 26, 2025 14:14
@kroening kroening enabled auto-merge February 27, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants