-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IGAPP-1152: Export events api client #831
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work. Tested on apple calendar and google calendar.
I have commented some minor adjustments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on web, works fine. In the designs the background of the button is grey instead of yellow, why did you choose yellow?
Co-authored-by: Steffen Kleinle <[email protected]>
…cription, add hostname and appName to iCal, pass PageFooter instead of button and text
Just added comment to design, since we should stick to our standard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, tested in Firefox. Have to concur with Steffen though, in the design the button is grey and wider. Nvm, just saw your previous comment about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, testes on Chrome
only one small thing:
Line length is too long for ical format (but it is only warning not error level)
https://icalendar.org/iCalendar-RFC-5545/3-1-content-lines.html
hm do you think we should force adding new lines? I imported in several calendars and couldn't find any issue. It will look very odd to randomly add news lines every ~20 chars @SteffiStuffel |
8c1e05e
to
3c2d232
Compare
This pull request also contains IGAPP-1129.
How to test it: Go to Events => Click on Item => click on export button
Import Google Kalendar: Settings -> Import & Export
For other applications: Just open ics file