Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release note for external calendars #3313

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

JoeyStk
Copy link
Contributor

@JoeyStk JoeyStk commented Jan 3, 2025

Short description

This PR adds the release note for the external calendars. This PR is one of the blocker for the next release. However we should wait for the final testing of @juliankehne until we merge this PR.

Proposed changes

  • Add release note.

Side effects

Resolved issues

Fixes: #100


Pull Request Review Guidelines

@JoeyStk JoeyStk added the blocker This issue blocks another issue label Jan 3, 2025
@MizukiTemma
Copy link
Member

@JoeyStk
Do you mean we release and reveal the feature? Then permission adjustment may be needed, because currently only Service Team and CMS Team can see, change and delete external calendars (unless it is so planned).

@JoeyStk
Copy link
Contributor Author

JoeyStk commented Jan 7, 2025

AFAIK for now that is the desired status and only members of the service team should be able to add new calendars. But maybe @osmers can give us an update if that's still the plan :)

@osmers
Copy link

osmers commented Jan 7, 2025

Yep, that's still the plan for now :) do we need a release note then or would it only confuse municipalities when they see the note but then cannot do anything?

@JoeyStk
Copy link
Contributor Author

JoeyStk commented Jan 7, 2025

Yep, that's still the plan for now :) do we need a release note then or would it only confuse municipalities when they see the note but then cannot do anything?

@osmers That's a good point. I'm a bit torn. I see your point, but then other the other hand I think there might be some municipalities, that might not hear about this feature? I think I would go all in: Add a release note, publish the blog post and maybe also write something in the authors chat. With this hopefully all interested municipalities learn about it in one form or another?

@osmers
Copy link

osmers commented Jan 7, 2025

@JoeyStk alrighty, that's ok by me - I think most municipalities will rather read the chat/blog than the release notes anyways :P

@JoeyStk
Copy link
Contributor Author

JoeyStk commented Jan 7, 2025

I think most municipalities will rather read the chat/blog than the release notes anyways :P

@osmers I think so too :)

@JoeyStk JoeyStk requested a review from jonbulz January 13, 2025 13:52
@JoeyStk JoeyStk force-pushed the release-note-for-external-calendars branch from 2936689 to 4107f6b Compare January 20, 2025 12:34
@JoeyStk JoeyStk merged commit 649fb3e into develop Jan 20, 2025
5 checks passed
@JoeyStk JoeyStk deleted the release-note-for-external-calendars branch January 20, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker This issue blocks another issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events: iCal subscription
4 participants