feat: add soundboard #10590
Open
feat: add soundboard #10590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
sdanialraza
force-pushed
the
feat/add-soundboard
branch
from
bb9d6a6 to
2ef1a3a
Compare
sdanialraza
force-pushed
the
feat/add-soundboard
branch
from
2ef1a3a to
57c2a7c
Compare
This comment has been minimized.
This comment has been minimized.
sdanialraza
force-pushed
the
feat/add-soundboard
branch
from
57c2a7c to
7821166
Compare
sdanialraza
force-pushed
the
feat/add-soundboard
branch
2 times, most recently
from
f3031c1 to
55725d0
Compare
sdanialraza
force-pushed
the
feat/add-soundboard
branch
from
55725d0 to
ce7db7f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10590 +/- ##
==========================================
- Coverage 39.15% 39.12% -0.03%
==========================================
Files 244 244
Lines 14804 14797 -7
Branches 1413 1414 +1
==========================================
- Hits 5796 5789 -7
Misses 8996 8996
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sdanialraza
force-pushed
the
feat/add-soundboard
branch
2 times, most recently
from
830929a to
1e0fb55
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
sdanialraza
force-pushed
the
feat/add-soundboard
branch
from
1e0fb55 to
1931f6e
Compare
sdanialraza
force-pushed
the
feat/add-soundboard
branch
from
1931f6e to
b61e513
Compare
sdanialraza
requested review from
ckohen,
vladfrangu,
iCrawl,
kyranet,
didinele,
Jiralite and
SpaceEEC
Qjuh
requested changes
Feb 27, 2025
| async create({ emojiId, emojiName, file, name, reason, volume }) { | ||
| const resolvedFile = await resolveFile(file); | ||
|
|
||
| const sound = resolveBase64(resolvedFile.data, 'audio/mp3'); |
There was a problem hiding this comment.
Shouldn't this support both mp3 and oggbased on the file type, not hardcoded to mp3?
There was a problem hiding this comment.
We can try:
- Take it as a required parameter from the user (I wouldn't go this route)
userParam ?? resolvedFile.contentType ?? lazilyLoadedMagicBytesLib()
packages/discord.js/src/managers/GuildSoundboardSoundManager.js
Outdated
Show resolved
Hide resolved
Qjuh
approved these changes
Mar 6, 2025
vladfrangu
requested changes
Mar 8, 2025
Comment on lines
+55
to
+73
| if ('emoji_id' in data) { | ||
| /** | ||
| * The emoji id of the soundboard sound | ||
| * @type {?Snowflake} | ||
| */ | ||
| this.emojiId = data.emoji_id; | ||
| } else { | ||
| this.emojiId ??= null; | ||
| } | ||
|
|
||
| if ('emoji_name' in data) { | ||
| /** | ||
| * The emoji name of the soundboard sound | ||
| * @type {?string} | ||
| */ | ||
| this.emojiName = data.emoji_name; | ||
| } else { | ||
| this.emojiName ??= null; | ||
| } |
There was a problem hiding this comment.
I'm not saying this so you change it, but I will call out that we should think if we wanna do emojis properly and use the emoji class instead of Discord's inconsistent handling of emojis across different objects.
Jiralite
reviewed
Mar 9, 2025
|
|
||
| /** | ||
| * Send a soundboard sound to a voice channel the user is connected to. | ||
| * Fires a Voice Channel Effect Send Gateway event. |
There was a problem hiding this comment.
There is a tag for this: @fires
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Adds soundboard for mainlib
Status and versioning classification: