Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: components v2 in builders v1 #10787

Open
wants to merge 16 commits into
base: builders/1.x
Choose a base branch
from

Conversation

Qjuh
Copy link
Contributor

@Qjuh Qjuh commented Mar 2, 2025

Please describe the changes this PR makes and why it should be merged:

The builders version for use in discord.js v14.

Depends on

The changes in the package discord.js are just needed so the tests don't fail. The target branch is never used for releasing discord.js.

Status and versioning classification:

Copy link

vercel bot commented Mar 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2025 10:46am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2025 10:46am

Copy link

codecov bot commented Mar 2, 2025

Codecov Report

Attention: Patch coverage is 98.79227% with 5 lines in your changes missing coverage. Please review.

Project coverage is 37.22%. Comparing base (53dbc96) to head (3800a61).

Files with missing lines Patch % Lines
packages/builders/src/components/Components.ts 92.50% 3 Missing ⚠️
packages/builders/src/components/Component.ts 75.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           builders/1.x   #10787      +/-   ##
================================================
+ Coverage         35.44%   37.22%   +1.78%     
================================================
  Files               228      237       +9     
  Lines             14319    14733     +414     
  Branches           1254     1334      +80     
================================================
+ Hits               5075     5484     +409     
- Misses             9200     9205       +5     
  Partials             44       44              
Flag Coverage Δ
builders 93.04% <98.79%> (+1.47%) ⬆️
guide 0.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Qjuh Qjuh marked this pull request as ready for review March 2, 2025 22:53
@Qjuh Qjuh requested review from a team and iCrawl as code owners March 2, 2025 22:53
@Qjuh Qjuh requested review from vladfrangu, kyranet, SpaceEEC, didinele and Jiralite and removed request for a team March 2, 2025 22:53
@Qjuh Qjuh changed the title feat(builders): components v2 in builders v1 feat: components v2 in builders v1 Mar 4, 2025
@Qjuh Qjuh removed the blocked label Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

1 participant