Update to React 0.11

[guersam]

• Use React 0.11, jstransform 6.0.1 WebJars
• Add sourceMapInline option
• Update other dependencies
• Use SBT macro instead of manual mapping

[dispalt]

Did you run the tests and verify a source map shows up? I don't know the new options, but this shim probably will need some changes if it doesn't. https://github.com/ddispaltro/sbt-reactjs/blob/master/src/main/resources/jsx.js I copied it as a template from the coffeescript compiler.

Thanks for the contributions!

[guersam]

Actually I couldn't do it yet because I'm not familar with sbt scripted
tests, but upon reading the shim code I think it'll work.

[dispalt]

ill give it a go, standby

[guersam]

Just fixed a JS param name and checked it working. If you want some tests I'll do it in a few days.

[dispalt]

Man something happen with logger inclusion in latest sbt plugin 2.3.2. Looks like it works though, I put the dep back to 2.3.0 and now I am not getting those errors. It looks related to sbt/sbt-native-packager#291 either way looks like it mostly works. It would be good to add a test to https://github.com/ddispaltro/sbt-reactjs/tree/master/src/sbt-test/sbt-reactjs outlining the new harmony/sourcemaps functionality. I never really had it working since sourcemaps never really worked. If you want I will commit it anyway.

[guersam]

Actually I'm not sure the web browsers understand inline source map, but the source map can be attached by the latest commit anyway. I'll revert play version and add some tests to this PR when I have some spare time.

BTW, do you have any plan for automated test via Travis CI?

[dispalt]

No plan, haven't thought about the travis stuff really at all. Is it possible to test sbt plugins with travis?

Btw to run the tests you just do

$ sbt
> scripted

[guersam]

Sure, you can override test command using script field in .travis.yml.

[guersam]

Added .travis.yml, fixed source map and added some tests. Please let me know if the tests fail, then I'll write a custom file command for it.

[dispalt]

Im going to merge and test travis

[dispalt]

Travis is working, I had to edit the jvmopts to give it more memory and move over to oraclejdk7 since I generally get more consistent performance from that. Thanks for the help @guersam!

[guersam]

Great, glad to contribute :)

[dispalt]

Pushed 0.3.0 to bintray.

On Tue, Jul 22, 2014 at 5:22 PM, Jisoo Park [email protected]
wrote:

Great, glad to contribute :)

—
Reply to this email directly or view it on GitHub
#3 (comment).

Dan Di Spaltro