Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if value_annot[key] is boolean, then issubclass(value_annot[key] raises exception #100

Merged
merged 1 commit into from
Apr 10, 2015
Merged

if value_annot[key] is boolean, then issubclass(value_annot[key] raises exception #100

merged 1 commit into from
Apr 10, 2015

Conversation

i2xS
Copy link
Contributor

@i2xS i2xS commented Mar 28, 2015

subj.

TypeError: issubclass() arg 1 must be a class

So we need to switch order of conditions.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 783f400 on i2xS:master into cb6830a on djangonauts:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.35% when pulling 783f400 on i2xS:master into cb6830a on djangonauts:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.35% when pulling 783f400 on i2xS:master into cb6830a on djangonauts:master.

@nemesifier
Copy link
Member

Hi @i2xS,
thank you for contributing.
Before mergin patches, we always add failing test cases.
What's the procedure to replicate the bug you're experiencing?
Federico

@i2xS i2xS mentioned this pull request Mar 30, 2015
Merged
@i2xS
Copy link
Contributor Author

i2xS commented Mar 30, 2015

Ok, sorry. PR with test here #102

@nemesifier nemesifier added the bug label Mar 31, 2015
@nemesifier nemesifier added this to the 1.3.6 milestone Mar 31, 2015
@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 783f400 on i2xS:master into eff0d84 on djangonauts:master.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 783f400 on i2xS:master into c36546b on djangonauts:master.

@nemesifier nemesifier merged commit 783f400 into djangonauts:master Apr 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.3.6
Development

Successfully merging this pull request may close these issues.
4 participants
@i2xS @landscape-bot @coveralls @nemesifier