Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change id to pk on model_instance check #110

Merged
merged 1 commit into from
Apr 29, 2015
Merged

change id to pk on model_instance check #110

merged 1 commit into from
Apr 29, 2015

Conversation

stringfellow
Copy link
Contributor

fixes #109

@stringfellow stringfellow changed the title change id to pk on model_instance check fixes #109 change id to pk on model_instance check Apr 28, 2015
@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling dab6442 on stringfellow:bugfix/id-or-pk into 160b8b8 on djangonauts:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.74% when pulling dab6442 on stringfellow:bugfix/id-or-pk into 160b8b8 on djangonauts:master.

@nemesifier
Copy link
Member

👍 thanks

nemesifier added a commit that referenced this pull request Apr 29, 2015
@nemesifier
Merge pull request #110 from stringfellow/bugfix/id-or-pk
d9a3c32 
Changed id to pk on model_instance check
@nemesifier nemesifier merged commit d9a3c32 into djangonauts:master Apr 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

id is not always a field on models, use pk instead
4 participants
@stringfellow @landscape-bot @coveralls @nemesifier