Add Clubs #133
Merged
Add Clubs #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Code Climate has analyzed commit 319d879 and detected 6 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 32.9% (80% is the threshold). This pull request will bring the total coverage in the repository to 47.9% (-0.8% change). View more on Code Climate. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -30,10 +32,10 @@ def build_source_url(league_bhv_id, team_bhv_id): | |||
| return f'{settings.ROOT_SOURCE_URL}Spielbetrieb/index.php?orgGrpID=1&score={league_bhv_id}&teamID={team_bhv_id}' | |||
|
|
|||
| @staticmethod | |||
| def create_or_update_team(name, short_name, league, bhv_id, logger: logging.Logger = logging.getLogger()): | |||
| def create_or_update_team(name, short_name, league, club, bhv_id, logger: logging.Logger = logging.getLogger()): | |||
There was a problem hiding this comment.
Function create_or_update_team has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
| import_club(association, name, bhv_id, options) | ||
|
|
||
|
|
||
| def import_club(association: Association, name: str, bhv_id, options): |
There was a problem hiding this comment.
Cyclomatic complexity is too high in function import_club. (6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Types
Description
With this new Feature you get an overview for all Teams of a specific Club.
Also you can easlily navigate from one Team to others of the same Club.
Checklist