Fix regressions in source maps #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkillerud
force-pushed
the
source-maps
branch
3 times, most recently
from
d329e37 to
b991f2d
Compare
Default to relative paths in the sources array.
|
@xzyfer, when you have the time, I have a regression fix for sourcemaps in The CI tests were a bit flaky on Windows around the removal of the |
|
Thanks for all your work @wkillerud. This all looks reasonable to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes source maps that broke in
6.0.0in some cases, by transforming the sourcemaps generated by the new Sass JS API to match the old output.file://URLs.data:<file contents>with relative path to file.Fixes #875