Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{lintr}
3.1.0 came out a few weeks ago: https://github.com/r-lib/lintr/releases/tag/v3.1.0It includes a few new linters, a bunch of bugfixes, and some new deprecation warnings.
{xgboost}
has already been using it, since this instalation is unpinned:xgboost/R-package/tests/helper_scripts/install_deps.R
Line 19 in a57371e
This PR proposes some changes to the R linting to better take advantage of that new version.
Fixes these warnings
And these errors
Notes for Reviewers
We made similar changes a few weeks ago in LightGBM and it's been working well so far: microsoft/LightGBM#5997
Thanks for your time and consideration!