Fix section title blank line errors in README.adoc #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #18 Fix the self_test_readme action to pass without false positives for section title blank line errors in `README.adoc`. * **Update `asciidoc_linter/rules/whitespace_rules.py`**: - Modify `WhitespaceRule` to account for attributes or roles after section titles. - Update `check_line` method to handle attributes and roles correctly. * **Add tests in `tests/rules/test_heading_rules.py`**: - Add tests for headings followed by attributes. - Add tests for headings followed by roles. * **Add test cases in `tests/test_linter.py`**: - Add test cases for headings followed by attributes or roles. * **Add test cases in `tests/test_reporter.py`**: - Add test cases for formatting errors with headings followed by attributes or roles. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/docToolchain/asciidoc-linter/issues/18?shareId=XXXX-XXXX-XXXX-XXXX).
…itles * Add debug output to `check_line` method to see why the whitespace_rules got triggered * Modify `check_line` method to account for attributes or roles after section titles * Add tests for attributes or roles after section titles in `test_heading_rules.py` * Add test cases for attributes or roles after section titles in `test_linter.py` * Add test cases for attributes or roles after section titles in `test_reporter.py`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #18
Fix the self_test_readme action to pass without false positives for section title blank line errors in
README.adoc.Update
asciidoc_linter/rules/whitespace_rules.py:WhitespaceRuleto account for attributes or roles after section titles.check_linemethod to handle attributes and roles correctly.Add tests in
tests/rules/test_heading_rules.py:Add test cases in
tests/test_linter.py:Add test cases in
tests/test_reporter.py:For more details, open the Copilot Workspace session.