Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(cloud): setup-buildx-action automatically fetches the buildx-private binary if driver == cloud #21618

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Dec 12, 2024

@dvdksn dvdksn added the status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. label Dec 12, 2024
Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 5b52f10
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/675ff8dee977870008147fe9
😎 Deploy Preview https://deploy-preview-21618--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@crazy-max
Copy link
Member

@dvdksn Fyi, also needs follow-up on docker/setup-buildx-action to vendor latest actions-toolkit version when released.

@dvdksn
Copy link
Contributor Author

dvdksn commented Dec 12, 2024

@crazy-max ack!

@dvdksn dvdksn force-pushed the dbc-gha-lab2cloud branch 3 times, most recently from 5eafe5f to b63c4e4 Compare December 12, 2024 15:31
@dvdksn dvdksn changed the title build(cloud): rename private buildx binary gha artifact to cloud:latest build(cloud): setup-buildx-action automatically fetches the buildx-private binary if driver == cloud Dec 12, 2024
No need to specify custom "version" input

Signed-off-by: David Karlsson <[email protected]>
@dvdksn dvdksn requested a review from crazy-max December 16, 2024 09:54
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dvdksn dvdksn removed the status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. label Dec 16, 2024
@dvdksn dvdksn merged commit 753cf3e into docker:main Dec 16, 2024
14 checks passed
@dvdksn dvdksn deleted the dbc-gha-lab2cloud branch December 16, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants