-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose all attempted execution migrations #1194
base: save-skipped-errored-migrations
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -11,8 +11,17 @@ interface MetadataStorage | |||||
{ | ||||||
public function ensureInitialized(): void; | ||||||
|
||||||
/** | ||||||
* Returns only the migrations that have been successfully executed (reason=executed) | ||||||
*/ | ||||||
public function getExecutedMigrations(): ExecutedMigrationsList; | ||||||
|
||||||
/** | ||||||
* Returns all the for which there was an execution attempt | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
* Includes skipped, errored executed migrations. | ||||||
*/ | ||||||
public function getAllExecutedMigrations(): ExecutedMigrationsList; | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what would be here the best way to add such functionality to this interface in a backward compatible way? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Usually something like
but I assume you're looking for something different? |
||||||
|
||||||
public function complete(ExecutionResult $migration): void; | ||||||
|
||||||
public function reset(): void; | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you decide not to use
?