Skip to content
This repository was archived by the owner on Dec 6, 2018. It is now read-only.

Handle special properties like __proto__ #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions shell.js
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,8 @@ var sublevel = module.exports = function (nut, prefix, createStream, options) {
}

emitter.sublevel = function (name, opts) {
return emitter.sublevels[name] =
emitter.sublevels[name] || sublevel(nut, prefix.concat(name), createStream, mergeOpts(opts))
return emitter.sublevels['$' + name] =
emitter.sublevels['$' + name] || sublevel(nut, prefix.concat(name), createStream, mergeOpts(opts))
}

emitter.pre = function (key, hook) {
Expand Down
45 changes: 45 additions & 0 deletions test/special-names.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
var levelup = require('level-test')()

var base = require('../')(levelup('test-sublevels'))

var test = require('tape')

test('special names', function (t) {
t.deepEqual(base.sublevels, {})

var cons = base.sublevel('constructor')
var proto = base.sublevel('__proto__')
var toString = base.sublevel('toString')

t.deepEqual(base.sublevels, {
'$constructor': cons,
'$__proto__': proto,
'$toString': toString
})
t.deepEqual(cons.sublevels, {})

t.strictEqual(base.sublevel('constructor'), cons)
t.strictEqual(base.sublevel('__proto__'), proto)
t.strictEqual(base.sublevel('toString'), toString)

t.deepEqual(cons.prefix(), ['constructor'])
t.deepEqual(proto.prefix(), ['__proto__'])
t.deepEqual(toString.prefix(), ['toString'])

var consBlerg = cons.sublevel('blerg')
t.deepEqual(cons.sublevels, {'$blerg': consBlerg})
t.strictEqual(cons.sublevel('blerg'), consBlerg)
t.deepEqual(consBlerg.prefix(), ['constructor', 'blerg'])

var consProto = cons.sublevel('__proto__')
t.deepEqual(cons.sublevels, {'$blerg': consBlerg, '$__proto__': consProto})
t.strictEqual(cons.sublevel('__proto__'), consProto)
t.deepEqual(consProto.prefix(), ['constructor', '__proto__'])

t.end()
})





4 changes: 2 additions & 2 deletions test/sublevels.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ test('subsections', function (t) {
var foo = base.sublevel('foo')
var bar = base.sublevel('bar')

t.deepEqual(base.sublevels, {foo: foo, bar: bar})
t.deepEqual(base.sublevels, {'$foo': foo, '$bar': bar})
t.deepEqual(foo.sublevels, {})

t.strictEqual(base.sublevel('foo'), foo)
Expand All @@ -20,7 +20,7 @@ test('subsections', function (t) {
console.log('prefix:', bar.prefix())

var fooBlerg = foo.sublevel('blerg')
t.deepEqual(foo.sublevels, {blerg: fooBlerg})
t.deepEqual(foo.sublevels, {'$blerg': fooBlerg})

t.strictEqual(foo.sublevel('blerg'), fooBlerg)

Expand Down