Skip to content
This repository was archived by the owner on Dec 6, 2018. It is now read-only.

Hotfix/sublevels compatibility #73

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions shell.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,15 @@ var version = require('./package.json').version

var sublevel = module.exports = function (nut, prefix, createStream, options) {
var emitter = new EventEmitter()
emitter.sublevels = {}
emitter._sublevels = {}
emitter.__defineGetter__("sublevels", function(){
var result = {}
for (var k in this._sublevels) {
result[k.substring(1)] = this._sublevels[k]
}
return result
})

emitter.options = options

emitter.version = version
Expand All @@ -35,10 +43,10 @@ var sublevel = module.exports = function (nut, prefix, createStream, options) {
var o = {}
if(options)
for(var k in options)
if(options[k] != undefined)o[k] = options[k]
if(options[k] !== undefined)o[k] = options[k]
if(opts)
for(var k in opts)
if(opts[k] != undefined) o[k] = opts[k]
if(opts[k] !== undefined) o[k] = opts[k]
return o
}

Expand Down Expand Up @@ -104,8 +112,8 @@ var sublevel = module.exports = function (nut, prefix, createStream, options) {
}

emitter.sublevel = function (name, opts) {
return emitter.sublevels[name] =
emitter.sublevels[name] || sublevel(nut, prefix.concat(name), createStream, mergeOpts(opts))
return emitter._sublevels['$' + name] =
emitter._sublevels['$' + name] || sublevel(nut, prefix.concat(name), createStream, mergeOpts(opts))
}

emitter.pre = function (key, hook) {
Expand Down
52 changes: 52 additions & 0 deletions test/special-names.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
var levelup = require('level-test')()

var base = require('../')(levelup('test-sublevels'))

var test = require('tape')

test('special names', function (t) {
t.deepEqual(base.sublevels, {})

var cons = base.sublevel('constructor')
var proto = base.sublevel('__proto__')
var toString = base.sublevel('toString')

t.deepEqual(base._sublevels, {
'$constructor': cons,
'$__proto__': proto,
'$toString': toString
})
t.deepEqual(base.sublevels, {
'constructor': cons,
'__proto__': proto,
'toString': toString
})
t.deepEqual(cons.sublevels, {})

t.strictEqual(base.sublevel('constructor'), cons)
t.strictEqual(base.sublevel('__proto__'), proto)
t.strictEqual(base.sublevel('toString'), toString)

t.deepEqual(cons.prefix(), ['constructor'])
t.deepEqual(proto.prefix(), ['__proto__'])
t.deepEqual(toString.prefix(), ['toString'])

var consBlerg = cons.sublevel('blerg')
t.deepEqual(cons._sublevels, {'$blerg': consBlerg})
t.deepEqual(cons.sublevels, {'blerg': consBlerg})
t.strictEqual(cons.sublevel('blerg'), consBlerg)
t.deepEqual(consBlerg.prefix(), ['constructor', 'blerg'])

var consProto = cons.sublevel('__proto__')
t.deepEqual(cons._sublevels, {'$blerg': consBlerg, '$__proto__': consProto})
t.deepEqual(cons.sublevels, {'blerg': consBlerg, '__proto__': consProto})
t.strictEqual(cons.sublevel('__proto__'), consProto)
t.deepEqual(consProto.prefix(), ['constructor', '__proto__'])

t.end()
})