ImGui.NET 1.90.8.1 #2230
Merged
ImGui.NET 1.90.8.1 #2230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has to be approached with caution. ImGui.NET consistently introduces TFM-specific breaking changes that we get the blame for, and this has generally resulted in a distaste for supporting ImGui.NET in Silk.NET. This isn’t a “no”, we just need to take some time to evaluate what’s happened upstream since the last time we updated. |
|
@dotnet-policy-service agree |
Use the `_keyboard` field rather than retrieving the first keyboard from the input context in `UpdateImGuiInput()` as it gets reset every frame to `_input.Keyboards[0]` in `BeginFrame()`.
… replace with the new `io.AddKeyEvent()` API. Also implemented `io.SetKeyEventNativeData()` to preserve legacy user code.
… and `Silk.NET.OpenGLES.Extensions.ImGui`.
matt-edmondson
requested review from
ThomasMiz,
Beyley and
a team
as code owners
Perksey
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Upgrade ImGui.NET to 1.90.8.1
Related issues, Discord discussions, or proposals
Further Comments