[generator] Disable [SupportedOSPlatform] until we can build with .NET 5/6. #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
approved these changes
Jan 14, 2021
jpobst
added a commit
that referenced
this pull request
May 14, 2021
…)" This reverts commit 00862ad.
jonpryor
pushed a commit
that referenced
this pull request
May 17, 2021
…)" (#841) Context: dotnet/android#5338 This reverts commit 00862ad. Now that we are properly building with `$(TargetFramework)`=net6.0 (4d0cba6), we can re-enable the `[SupportedOSPlatform]` support, as originally introduced in da12df4. Emit the [`System.Runtime.Versioning.SupportedOSPlatformAttribute`][0] custom attribute which is used to specify on which platforms and platform versions an API is available. This is used to build analyzers to give users warnings if they are trying to use an API when it will not be available on their target platform. [0]: https://docs.microsoft.com/en-us/dotnet/api/system.runtime.versioning.supportedosplatformattribute?view=net-5.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#5497
We cannot currently build
net5.0ornet6.0assemblies in our XA tree and instead do some workaround that involves compiling withnetcoreapp3.1but referencing 5.0 BCL. This creates a conflict between the local[SupportedOSPlatform]we create innetcoreapp3.1Mono.Android.dll, and the real one in the 5.0 BCL.We will disable generating these attributes until we can build
Mono.Android.dllwithNET, in which case it will not contain the local attribute.