Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support stripping custom attributes on generic constraints #632

Closed
sbomer opened this issue Jun 21, 2019 · 0 comments · Fixed by #747
Closed

Support stripping custom attributes on generic constraints #632

sbomer opened this issue Jun 21, 2019 · 0 comments · Fixed by #747

Comments

@sbomer
Copy link
Member

sbomer commented Jun 21, 2019 •
edited
Loading

It looks like the Nullable feature is adding support for specifying attributes on generic constraints. As far as I can tell from the discussion in dotnet/roslyn#29997, this was not previously allowed in IL. Once cecil updates to support this (jbevain/cecil#594), the linker will need to as well.

Note that the linker already supports stripping attributes on InterfaceImpls (#571).
marek-safar added a commit to marek-safar/linker that referenced this issue Sep 13, 2019
@marek-safar
Add sweeping of attributes on type parameter contraints
0a13ee2 
Fixes dotnet#632
marek-safar added a commit to marek-safar/linker that referenced this issue Sep 13, 2019
@marek-safar
Add sweeping of attributes on type parameter constraints
d789381 
Fixes dotnet#632
@marek-safar marek-safar mentioned this issue Sep 13, 2019
Merged
marek-safar added a commit that referenced this issue Sep 24, 2019
@marek-safar
Add sweeping of attributes on type parameter constraints (#747)
01fbea1 
* Add sweeping of attributes on type parameter constraints

Fixes #632

* Switch to C# 8.0 for tests
tkapin pushed a commit to tkapin/runtime that referenced this issue Jan 31, 2023
@marek-safar
Add sweeping of attributes on type parameter constraints (dotnet/link…
79a8907 
…er#747)

* Add sweeping of attributes on type parameter constraints

Fixes dotnet/linker#632

* Switch to C# 8.0 for tests


Commit migrated from dotnet/linker@01fbea1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add sweeping of attributes on type parameter constraints marek-safar/linker
1 participant
@sbomer